Improve error messaging for step_cut() with missing data
#1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tidymodels#1351 Updated the `create_full_breaks()` function to provide a more informative error message when `step_cut()` is applied to a column containing missing values (`NA`). The function now checks for missing data and warns users appropriately.
|
Looking great! would you kindly add some snapshot tests using Those tests should be placed above https://github.com/tidymodels/recipes/blob/main/tests/testthat/test-cut.R#L171 |
|
Sure thing - thanks for the feedback! |
…managed by `recipes_error_context`
|
I've added the snapshot tests and pushed the changes. Please take a look when you have a moment. Thanks again!! |
|
Thanks for the contribution! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1351
Updated the
create_full_breaks()function to provide a more informative error message whenstep_cut()is applied to a column containing missing values (NA). The function now checks for missing data and warns users appropriately.