turn table to tibble in recipe.formula #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
reviewed
Jan 22, 2025
| @@ -209,6 +209,10 @@ recipe.formula <- function(formula, data, ...) { | |||
| cli::cli_abort("{.arg data} is missing with no default.") | |||
| } | |||
|
|
|||
| if (is.table(data)) { | |||
There was a problem hiding this comment.
Should we add a warning or deprecation notice for this? I'd like to get rid of this down the road; it shouldn't be supported.
There was a problem hiding this comment.
sure, i'm gonna add a warning and remove this in the following release with #1416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was found during revdepcheck: spsanderson/healthyR.ai#349
we didn't use to check what type the data was that was passed to
recipe.formula()which resulted in anything that passedtibble::as_tibble()worked. This is not ideal. This PR lets us release soon without having to fix it. Then we can later remove it so the functions does what the documentation says