Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in collect_metrics() error #785

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix spelling in collect_metrics() error #785

merged 2 commits into from
Dec 15, 2023

Conversation

EmilHvitfeldt
Copy link
Member

I went a little over the brief, and converted all 4 of the errors to use cli (and fix the typo) while I was at it

to close #770

Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!🙂

#' in the `collect_extracts()` output, tune opts to associate the
#' extracted objects with the hyperparameter combination used to
#' fit that one model workflow, rather than the hyperparameter
#' combination of a submodel. In the output, this appears like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there .Rd changes associated with these deletions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no :( i couldn't figure out how to get rid of it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

@EmilHvitfeldt EmilHvitfeldt merged commit e6b3309 into main Dec 15, 2023
9 checks passed
@EmilHvitfeldt EmilHvitfeldt deleted the fix770 branch December 15, 2023 19:39
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collect_metrics() error misspells functions name
2 participants