Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old guides in guides() #6167

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6165.

Briefly, it rectifies the mistake that we should've been testing old S3 guides with the 'guide' class instead of modern ggproto guides with the 'Guide' class.

Reprex from issue:

devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2

guides(x = guide_axis())
#> <Guides[1] ggproto object>
#> 
#> x : <GuideAxis>

guides(x = ggprism::guide_prism_minor())
#> <Guides[1] ggproto object>
#> 
#> x : <guide>

Created on 2024-10-29 with reprex v2.1.1

@teunbrand teunbrand changed the title Restore old guide Restore old guides in guides() Oct 29, 2024
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 3d1102c into tidyverse:main Jan 21, 2025
13 checks passed
@teunbrand teunbrand deleted the restore_old_guide branch January 21, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed old guides
2 participants