Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft lifecycle 0.1.0 post #326

Closed
wants to merge 18 commits into from
Closed

Draft lifecycle 0.1.0 post #326

wants to merge 18 commits into from

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Aug 1, 2019

No description provided.

@lionel- lionel- force-pushed the add-lifecycle-0-1-0 branch from c56c19d to 84f33dc Compare August 1, 2019 16:33
@lionel- lionel- force-pushed the add-lifecycle-0-1-0 branch from 6af90c9 to 7af559a Compare August 1, 2019 17:03
Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm eager to start using this, so I read & reviewed. I asked a few questions that came to mind.

Maybe point at one or more packages that are already using this, in case people want to see usage in the wild?

content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@batpigandme batpigandme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited about this package. Just a few suggestions.

content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
@lionel-
Copy link
Member Author

lionel- commented Aug 5, 2019

Thanks for the reviews @jennybc and @batpigandme, I think all is now addressed.

content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
content/articles/2019-08-lifecycle-0-1-0.Rmarkdown Outdated Show resolved Hide resolved
@lionel-
Copy link
Member Author

lionel- commented Aug 6, 2019

@batpigandme @hadley I have now documented the forgotten "retired" stage. I have included both retired and deprecated stages in a broader "Termination stages" category, in contrast to the "Development stages". Does this make sense?

@jennybc
Copy link
Member

jennybc commented Feb 4, 2020

Does this need to be changed again to reflect "retired" → "superseded"?

@hadley
Copy link
Member

hadley commented Apr 19, 2020

Fixes #114.

Is it worth finishing this off and getting it published next week?

@hadley
Copy link
Member

hadley commented Dec 8, 2021

Should we close this since we did https://www.tidyverse.org/blog/2021/02/lifecycle-1-0-0/ ?

@lionel-
Copy link
Member Author

lionel- commented Dec 8, 2021

yup I had completely forgot about this one.

@lionel- lionel- closed this Dec 8, 2021
@lionel- lionel- deleted the add-lifecycle-0-1-0 branch December 8, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants