Skip to content

Commit

Permalink
chore(hesai): disallow 255.255.255.255 in config
Browse files Browse the repository at this point in the history
Signed-off-by: Max SCHMELLER <[email protected]>
  • Loading branch information
mojomex committed Dec 23, 2024
1 parent 0d01f36 commit bb1e8e7
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions nebula_ros/src/hesai/hesai_ros_wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,13 @@ Status HesaiRosWrapper::validate_and_set_config(
if (new_config->frame_id.empty()) {
return Status::SENSOR_CONFIG_ERROR;
}
if (new_config->host_ip == "255.255.255.255") {
RCLCPP_ERROR(
get_logger(),
"Due to potential network performance issues when using IP broadcast for sensor data, Nebula "
"disallows use of the broadcast IP. Please specify the concrete host IP instead.");
return Status::SENSOR_CONFIG_ERROR;
}
if (new_config->ptp_profile == nebula::drivers::PtpProfile::UNKNOWN_PROFILE) {
RCLCPP_ERROR(
get_logger(), "Invalid PTP Profile Provided. Please use '1588v2', '802.1as' or 'automotive'");
Expand Down

0 comments on commit bb1e8e7

Please sign in to comment.