Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hesai,velodyne): combine connection-related parameters into connection_mode #211

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

chore: fix typo in connection_mode schema

e29d0cd
Select commit
Loading
Failed to load commit list.
Open

chore(hesai,velodyne): combine connection-related parameters into connection_mode #211

chore: fix typo in connection_mode schema
e29d0cd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 25, 2024 in 0s

0.00% of diff hit (target 25.88%)

View this Pull Request on Codecov

0.00% of diff hit (target 25.88%)

Annotations

Check warning on line 376 in nebula_common/include/nebula_common/nebula_common.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_common/include/nebula_common/nebula_common.hpp#L376 

Added line #L376 was not covered by tests

Check warning on line 380 in nebula_common/include/nebula_common/nebula_common.hpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_common/include/nebula_common/nebula_common.hpp#L380 

Added line #L380 was not covered by tests

Check warning on line 44 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L43-L44 

Added lines #L43 - L44 were not covered by tests

Check warning on line 55 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L55 

Added line #L55 was not covered by tests

Check warning on line 62 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L62 

Added line #L62 was not covered by tests

Check warning on line 69 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L69 

Added line #L69 was not covered by tests

Check warning on line 81 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L79-L81 

Added lines #L79 - L81 were not covered by tests

Check warning on line 469 in nebula_ros/src/hesai/hesai_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hesai_ros_wrapper.cpp#L469 

Added line #L469 was not covered by tests

Check warning on line 17 in nebula_ros/src/hesai/hw_interface_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hw_interface_wrapper.cpp#L17 

Added line #L17 was not covered by tests

Check warning on line 21 in nebula_ros/src/hesai/hw_interface_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/hesai/hw_interface_wrapper.cpp#L21 

Added line #L21 was not covered by tests

Check warning on line 15 in nebula_ros/src/velodyne/hw_interface_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/velodyne/hw_interface_wrapper.cpp#L15 

Added line #L15 was not covered by tests

Check warning on line 19 in nebula_ros/src/velodyne/hw_interface_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/velodyne/hw_interface_wrapper.cpp#L19 

Added line #L19 was not covered by tests

Check warning on line 33 in nebula_ros/src/velodyne/velodyne_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/velodyne/velodyne_ros_wrapper.cpp#L32-L33 

Added lines #L32 - L33 were not covered by tests

Check warning on line 44 in nebula_ros/src/velodyne/velodyne_ros_wrapper.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

nebula_ros/src/velodyne/velodyne_ros_wrapper.cpp#L44 

Added line #L44 was not covered by tests
View more details on Codecov