Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ars548): disable object output for corner radars #252

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

knzo25
Copy link
Collaborator

@knzo25 knzo25 commented Jan 17, 2025

PR Type

  • Bug Fix

Related Links

Description

We were publishing objects for corner radars, which is not a supported feature (from the sensor).
This PR disables them and provides warnings when users attempt to use corner radars

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

This essentially assumes that continental ignores the configuration's yaw for FRONT corner radars.
Kinematics will be wrong no matter what...

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…s (it should only be for evaluation purposes)

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
@knzo25 knzo25 requested a review from mojomex January 17, 2025 06:47
@mojomex mojomex changed the title Feat/disable corner radars ars548 feat(ars548): disable corner radars ars548 Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 27.18%. Comparing base (77b4c6c) to head (99ccb0f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...continental/continental_ars548_decoder_wrapper.cpp 0.00% 5 Missing ⚠️
...ontinental/decoders/continental_ars548_decoder.cpp 0.00% 0 Missing and 1 partial ⚠️
...nental/continental_ars548_hw_interface_wrapper.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   26.11%   27.18%   +1.07%     
==========================================
  Files         100      104       +4     
  Lines        9214     9464     +250     
  Branches     2214     2326     +112     
==========================================
+ Hits         2406     2573     +167     
- Misses       6419     6455      +36     
- Partials      389      436      +47     
Flag Coverage Δ
differential 27.18% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex changed the title feat(ars548): disable corner radars ars548 feat(ars548): disable object output for corner radars Jan 17, 2025
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
As for the 5.0 and 90.0 degrees, are they documented somewhere or empirical?
I also left a small comment for refactoring 🙇

Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants