-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ars548): disable object output for corner radars #252
base: main
Are you sure you want to change the base?
Conversation
This essentially assumes that continental ignores the configuration's yaw for FRONT corner radars. Kinematics will be wrong no matter what... Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…s (it should only be for evaluation purposes) Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 26.11% 27.18% +1.07%
==========================================
Files 100 104 +4
Lines 9214 9464 +250
Branches 2214 2326 +112
==========================================
+ Hits 2406 2573 +167
- Misses 6419 6455 +36
- Partials 389 436 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
As for the 5.0
and 90.0
degrees, are they documented somewhere or empirical?
I also left a small comment for refactoring 🙇
nebula_decoders/src/nebula_decoders_continental/decoders/continental_ars548_decoder.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Type
Related Links
Description
We were publishing objects for corner radars, which is not a supported feature (from the sensor).
This PR disables them and provides warnings when users attempt to use corner radars
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks