-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] action: use coverage.py directly in test CI #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodong-Yang
force-pushed
the
chore/use_coverage_py
branch
from
November 16, 2023 07:13
2db773a
to
d4db360
Compare
Bodong-Yang
force-pushed
the
chore/use_coverage_py
branch
from
November 16, 2023 07:16
d4db360
to
3176089
Compare
Bodong-Yang
added
build/ci
Related to package build or CI
chore
Pull requests that do not relate to a fix or feature and don't modify source code(like tagging, etc)
labels
Nov 16, 2023
6 tasks
obi-t4
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important
This PR is required by #264 , as more fine grained control over how coverage.py is executed is needed.
This PR introduces changes to run test with coverage by directly using
coverage run -m pytest
instead of using pytest with pytest-cov plugin.Also, this PR bumps action
MishaKav/pytest-coverage-comment
to 1.1.49, and exposes test result with junitxml.Check the test coverage result comment in this PR for more details.
Motivation
Actually
pytest-cov
is a wrapper plugin that callscoverage.py
underhook. According tocoverage
documentation:Actually we don't need to use
pytest-cov
plugin for our purpose. In contrast, with wrapperpytest-cov
plugin, we are not able to configurecoverage
's execution directly. To controlcoverage.py
's execution directly, we should avoid using any wrapper.Finally,
pytest-cov
plugin is not in active maintain now, whilecoverage.py
itself is still actively maintained, we should refer to the upstream instead using a wrapper.