Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Build for Arm64 #1424

Closed
wants to merge 3 commits into from
Closed

Fix Docker Build for Arm64 #1424

wants to merge 3 commits into from

Conversation

takanotaiga
Copy link
Member

Description

This pull request introduces a new GitHub Actions workflow for building Docker images targeting the Arm64 architecture. It aims to address the previously broken Arm64 build process by creating a separate workflow file for Arm64 builds.

Abstract

This PR fixes the Docker build process for Arm64 by adding a new workflow file .github/workflows/DockerArm64.yaml, which includes the necessary steps and configurations for building and pushing Arm64-compatible images.

Background

The Docker build process for Arm64 was previously broken, as noted in pull request #1295. This issue was temporarily addressed by limiting the builds to amd64 only. This PR seeks to resolve this by reintroducing a dedicated workflow for Arm64.

Details

The new workflow file .github/workflows/DockerArm64.yaml includes:

  • A push_docker job for building and pushing Docker images targeting the Arm64 architecture.
  • The use of docker/setup-buildx-action and docker/setup-qemu-action to ensure compatibility with Arm64 builds.
  • Conditional logic to handle build triggers for both pull_request and workflow_dispatch events.
  • Removal of previous Arm64-related comments from the main Docker.yaml workflow file.

Important

This action is separated with the assumption that Arm64 runners will be introduced in the future. Running the Docker command directly is the only solution that has been confirmed so far.

References

Destructive Changes

N/A

Known Limitations

N/A

Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@takanotaiga takanotaiga self-assigned this Oct 16, 2024
@takanotaiga takanotaiga added the bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 label Oct 16, 2024
@takanotaiga takanotaiga deleted the fix/ci-arm-docker branch October 21, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant