Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix iclude guards and update xsd comments #1504

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Jan 8, 2025

Description

Abstract

  • fix iclude guards
  • update xsd comments

Background

The original pull-request for ParameterValueDistribution is too big to review.
So, I divide it to some small pull-requests.
This is the first one.

References

#1253

Destructive Changes

None

Known Limitations

None

Copy link

github-actions bot commented Jan 8, 2025

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo changed the title Refactor/parameter value distribution chore: fix iclude guards and update xsd comments Jan 9, 2025
@HansRobo HansRobo added bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test labels Jan 15, 2025
@HansRobo HansRobo requested a review from yamacir-kit January 16, 2025 01:11
@HansRobo HansRobo marked this pull request as ready for review January 16, 2025 01:14
@HansRobo HansRobo merged commit ea32884 into master Jan 17, 2025
20 checks passed
@HansRobo HansRobo deleted the refactor/parameter_value_distribution branch January 17, 2025 08:00
@github-actions github-actions bot restored the refactor/parameter_value_distribution branch January 17, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants