Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(visualize): add support of loading global map origin from yaml #70

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

ktro2828
Copy link
Collaborator

@ktro2828 ktro2828 commented Dec 13, 2024

What

This PR introduces rendering geometric coordinates from the global map origin and ego position at the particular timestamp even if EgoPose.geocoordinate is None.

The global map origin is parsed from map/global_map_center.pcd.yaml if it is contained.
The expected format of global_map_center.pcd.yaml is as follows:

/**:
  ros__parameters:
    map_origin:
      latitude: 35.223124955115864
      longitude: 138.80245834628386
      elevation: 0.0
      roll: 0.0
      pitch: 0.0
      yaw: 0.0

@github-actions github-actions bot added the new-feature New feature or request label Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

☂️ Python Coverage

current status: ❌

Overall Coverage

Lines Covered Coverage Threshold Status
2142 1443 67% 50% 🟢

New Files

File Coverage Status
t4_devkit/viewer/geography.py 50% 🔴
TOTAL 50% 🔴

Modified Files

File Coverage Status
t4_devkit/tier4.py 10% 🔴
t4_devkit/viewer/init.py 100% 🟢
t4_devkit/viewer/viewer.py 78% 🔴
TOTAL 62% 🔴

updated for commit: 8354993 by action🐍

@ktro2828 ktro2828 force-pushed the feat/visualize/map-origin branch 2 times, most recently from 4ebf8c7 to 8fdd3e5 Compare December 21, 2024 07:06
@ktro2828 ktro2828 force-pushed the feat/visualize/map-origin branch from 8fdd3e5 to 8354993 Compare December 26, 2024 10:47
@ktro2828 ktro2828 marked this pull request as ready for review December 26, 2024 10:48
@ktro2828 ktro2828 merged commit a6a72f7 into main Dec 26, 2024
4 of 5 checks passed
@ktro2828 ktro2828 deleted the feat/visualize/map-origin branch December 26, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant