-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to docker hub #2
base: main
Are you sure you want to change the base?
Conversation
046ab4e
to
4f7dc68
Compare
From my point of view, I'd prefer to have an automated build, rather than pushing a Docker image:
The project would have only a Dockerfile, nothing else. Having a automated build is more trusted than a Docker image which has been pushed. |
I don't understand your point because to make the image I build the sources from CI to obtain dist folder and add the result to the docker image. So your strategy is completely different because I should build the dist from the image and it's not the way I choose. Or I don't understand what you want to do at goal. |
I will apply some changes in order to use Docker directly instead of using a plugin |
@Gnuk : do you need help to achieve this ? |
If you want @pascalgrimaud don't hesitate to be the owner of this issue ;) |
@Gnuk : as you are the lead of Tikui, how should we achieve this ?
|
WIth the second solution, are we able to wait it's done (or failing) during the pipeline ? |
Closes #1