k8s: add websocket support to exec #6496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Konrad <[email protected]>
ChyZma
force-pushed
the
exec-websocket
branch
from
2f64517 to
d82d912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.31, Kubernetes switched from SPDY to WebSockets for streaming (blog post).
For clusters where SPDY is unavailable (e.g., the Kubernetes API server is accessed through an edge proxy that doesn't support SPDY), the
execoperation must use WebSockets.A possible solution for this would be to use a WebSocket Stream Executor by default and fall back to a SPDY Stream Executor when WebSocket based streaming is unavailable. (this also aligns with what
kubectl execcurrently does)I also replaced
Executor.StreamwithExecutor.StreamWithContextbecause the former is deprecated.(A similar solution could be used to solve #6445. I might check it out over the weekend.)