Refactor compression filter handling #6329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@konskov, @mahipv: please review this pull request.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6329 +/- ##
==========================================
- Coverage 65.46% 59.00% -6.46%
==========================================
Files 249 249
Lines 57996 50215 -7781
Branches 12919 12575 -344
==========================================
- Hits 37966 29629 -8337
+ Misses 18165 16084 -2081
- Partials 1865 4502 +2637 ☔ View full report in Codecov by Sentry. |
svenklemm
requested review from
antekresic,
akuzm,
jnidzwetzki and
fabriziomello
antekresic
approved these changes
Nov 20, 2023
tsl/src/compression/compression.h
Outdated
| * The columns will either be segmentby columns or the corresponding | ||
| * metadata columns of orderby columns. | ||
| */ | ||
| typedef struct CompressedFilter |
There was a problem hiding this comment.
nit: Maybe BatchFilter is even better?
svenklemm
force-pushed
the
comp_indirection
branch
from
1364580 to
77f7167
Compare
akuzm
approved these changes
Nov 20, 2023
Change the code to have less direct references to FormData_hypertable_compression. The patch also renames SegmentFilter to BatchFilter to make the purpose clearer.
svenklemm
force-pushed
the
comp_indirection
branch
from
77f7167 to
95d4d39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the code to have less direct references to FormData_hypertable_compression. The patch also renames SegmentFilter to BatchFilter to make the purpose clearer.
Disable-check: force-changelog-file