Revert "Restart scheduler on error" #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bebd1ab. We have discovered that the BGW slot is not freed in all cases. In this case, no more new workers can be created. So, the patch is rolled back until the bug has been corrected.
|
@akuzm, @fabriziomello: please review this pull request.
|
mkindahl
approved these changes
Nov 21, 2023
fabriziomello
approved these changes
Nov 21, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6335 +/- ##
==========================================
- Coverage 65.48% 65.40% -0.08%
==========================================
Files 249 249
Lines 57995 57947 -48
Branches 12920 12901 -19
==========================================
- Hits 37980 37903 -77
- Misses 18157 18207 +50
+ Partials 1858 1837 -21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bebd1ab. We have discovered that the BGW slot is not freed in all cases. In this case, no more new workers can be created. So, the patch is rolled back until the bug has been corrected.
Disable-check: force-changelog-file