Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload test results for macos regression CI #6449

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

antekresic
Copy link
Contributor

@antekresic antekresic commented Dec 20, 2023

Most if not all commits have failed on the main branch due to macos-13 regression tests failing to upload test results to CI database. Switching to using libpq psql seems to fix the issue.

https://github.com/timescale/timescaledb/actions/workflows/linux-build-and-test.yaml?query=is%3Afailure+branch%3Amain

This PR success CI run: https://github.com/timescale/timescaledb/actions/runs/7276339952/job/19826008689?pr=6449

Disable-check: force-changelog-file

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f2f658) 87.33% compared to head (ffe8c76) 87.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6449      +/-   ##
==========================================
- Coverage   87.33%   87.30%   -0.04%     
==========================================
  Files         187      187              
  Lines       41820    41774      -46     
  Branches     9313     9293      -20     
==========================================
- Hits        36525    36472      -53     
- Misses       3623     3631       +8     
+ Partials     1672     1671       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antekresic antekresic force-pushed the akresic-debug-macos branch 5 times, most recently from 8c7e022 to 45d27b9 Compare December 20, 2023 13:40
@antekresic antekresic changed the title Debug macos CI upload to test database issue Fix upload test results for macos regression CI Dec 20, 2023
@antekresic antekresic requested a review from nikkhils December 20, 2023 13:40
@antekresic antekresic added the ci label Dec 20, 2023
@antekresic antekresic requested a review from svenklemm December 20, 2023 13:40
@antekresic antekresic marked this pull request as ready for review December 20, 2023 14:04
Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the /usr/local/opt/libpq/bin directory contains PSQL binary as required.

@antekresic antekresic merged commit 2f6d1b6 into main Dec 21, 2023
41 checks passed
@antekresic antekresic deleted the akresic-debug-macos branch December 21, 2023 08:03
@fabriziomello fabriziomello added the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label Dec 21, 2023
@timescale-automation
Copy link
Member

Automated backport to 2.13.x not done: backport failed.

The PR touches a workflow file '.github/workflows/linux-build-and-test.yaml' and cannot be backported automatically

Job log

@timescale-automation timescale-automation added auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) backported-2.13.x labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) ci force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants