Backport to 2.13.x: #6405: Read watermark from materialized data #6457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timescale-automation
added
the
is-auto-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.13.x #6457 +/- ##
=========================================
Coverage ? 82.45%
=========================================
Files ? 249
Lines ? 57952
Branches ? 12899
=========================================
Hits ? 47785
Misses ? 6746
Partials ? 3421 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
force-pushed
the
backport/2.13.x/6405
branch
from
950ef84 to
ce5941e
Compare
In 38fcd1b we improved the cagg_watermark performance by storing it into a metadata table and update it during the refresh. But we made a minor mistake here reading the watermark from the partial view instead of the already materialized data that should be much fast because we're reading already aggregated data. Fixed this mistake by reading the watermark from the underlying materialization hypertable (already aggregated data). (cherry picked from commit 3d93bfb)
jnidzwetzki
force-pushed
the
backport/2.13.x/6405
branch
from
ce5941e to
bab9122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #6405: Read watermark from materialized data.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Read watermark from materialized data
In 38fcd1b we improved the cagg_watermark performance by storing it into a metadata table and update it during the refresh.
But we made a minor mistake here reading the watermark from the partial view instead of the already materialized data that should be much fast because we're reading already aggregated data.
Fixed this mistake by reading the watermark from the underlying materialization hypertable (already aggregated data).
Disable-check: force-changelog-file