-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk decompression of text columns #6458
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6458 +/- ##
==========================================
- Coverage 79.79% 79.78% -0.01%
==========================================
Files 190 190
Lines 36949 37101 +152
Branches 9356 9403 +47
==========================================
+ Hits 29482 29600 +118
- Misses 3116 3127 +11
- Partials 4351 4374 +23 ☔ View full report in Codecov by Sentry. |
@fabriziomello, @antekresic: please review this pull request.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have test files/functions in dedicated direcotry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why the PR is light on sql tests? I see a bunch of fuzzing tests were added but that's mostly it.
Since the bulk decompression is enabled by default, it is covered by many existing tests that use text columns. I plan to add some SQL tests when we have vectorized filters on text columns: https://github.com/timescale/timescaledb/pull/6189/files#diff-0068ab49636b29bd1b20ebdd4f87f04251dae1a461f499500179100eab2c2494 |
Moved them to |
Implement bulk decompression for text columns. This will allow us to use them in the vectorized computation pipeline.
f770fd3
to
7985c76
Compare
Implement bulk decompression for text columns. This will allow us to use them in the vectorized computation pipeline.
No changes in performance: https://grafana.ops.savannah-dev.timescale.com/d/fasYic_4z/compare-akuzm?orgId=1&var-branch=All&var-run1=3093&var-run2=3078&var-threshold=0&var-use_historical_thresholds=true&var-threshold_expression=2.5%20*%20percentile_cont(0.90)&var-exact_suite_version=false
Disable-check: force-changelog-file