Fix lock order when dropping index #7600
Merged
+240
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
fix-index-deadlock
branch
2 times, most recently
from
1f7a183 to
951b92a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7600 +/- ##
==========================================
+ Coverage 80.06% 81.32% +1.25%
==========================================
Files 190 240 +50
Lines 37181 44708 +7527
Branches 9450 11164 +1714
==========================================
+ Hits 29770 36359 +6589
- Misses 2997 3960 +963
+ Partials 4414 4389 -25 ☔ View full report in Codecov by Sentry. |
mkindahl
force-pushed
the
fix-index-deadlock
branch
from
951b92a to
0f5b107
Compare
erimatnor
reviewed
Jan 20, 2025
mkindahl
force-pushed
the
fix-index-deadlock
branch
from
431478a to
4504ac8
Compare
mkindahl
force-pushed
the
fix-index-deadlock
branch
from
4504ac8 to
ed951cf
Compare
mkindahl
force-pushed
the
fix-index-deadlock
branch
2 times, most recently
from
a7bd859 to
8f0c997
Compare
mkindahl
force-pushed
the
fix-index-deadlock
branch
from
019509c to
f0e2cd1
Compare
If an index is dropped, it is necessary to lock the heap table (of the index) before the index since all normal operations do it in this order. When dropping an index, we did not take all the necessary locks in the right order before calling `performMultipleDeletions`, which can cause deadlocks when dropping an index on a hypertable at the same time as running a utility statement that takes heavy locks, e.g., VACUUM or ANALYZE. Adding a isolation test as well that will generate a deadlock if the index and table locks are not taken in the correct order.
mkindahl
force-pushed
the
fix-index-deadlock
branch
from
f0e2cd1 to
e584632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an index is dropped, it is necessary to lock the heap table (of
the index) before the index since all normal operations do it in this
order. When dropping an index, we did not take all the necessary locks
in the right order before calling
performMultipleDeletions, which cancause deadlocks when dropping an index on a hypertable at the same time
as running a utility statement that takes heavy locks, e.g., VACUUM or
ANALYZE.
Adding a isolation test as well that will generate a deadlock if the
index and table locks are not taken in the correct order.