Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 2.18.x: #7637: Allow EXPLAIN in read-only mode #7641

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

timescale-automation
Copy link
Member

This is an automated backport of #7637: Allow EXPLAIN in read-only mode.
The original issue is #7635.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.

For more details, please see the documentation

Original description

Allow EXPLAIN in read-only mode

Using EXPLAIN when transaction_read_only is set to on fails with an error. This is fixed by explicitly setting the check_read_only flag.

Fixes #7635

@ikalafat
Copy link

ikalafat commented Feb 2, 2025

hi @mkindahl

will this merged/backported to 2.18.1 since the checks are failing? thanks

@mkindahl
Copy link
Contributor

mkindahl commented Feb 3, 2025

hi @mkindahl

will this merged/backported to 2.18.1 since the checks are failing? thanks

This is an automatic backport, but it occasionally fails if there are to big differences in the patch. In those cases, we backport it manually.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mkindahl
❌ timescale-automation
You have signed the CLA already but the status is still pending? Let us recheck it.

@mkindahl mkindahl force-pushed the backport/2.18.x/7637 branch 2 times, most recently from c2f51bf to faced19 Compare February 3, 2025 15:47
Using `EXPLAIN` when `transaction_read_only` is set to `on` fails with
an error. This is fixed by explicitly setting the `check_read_only`
flag.

(cherry picked from commit 39049fe)
@mkindahl mkindahl force-pushed the backport/2.18.x/7637 branch from faced19 to a8f7675 Compare February 3, 2025 16:15
@timescale-automation timescale-automation merged commit 9c59317 into 2.18.x Feb 4, 2025
41 checks passed
@timescale-automation timescale-automation deleted the backport/2.18.x/7637 branch February 4, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-auto-backport PR created by backport automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants