Add support for merging compressed chunks #7669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
force-pushed
the
merge-chunks-compressed
branch
from
87d3db9 to
1aa10b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7669 +/- ##
==========================================
+ Coverage 80.06% 81.98% +1.91%
==========================================
Files 190 246 +56
Lines 37181 45308 +8127
Branches 9450 11316 +1866
==========================================
+ Hits 29770 37147 +7377
- Misses 2997 3704 +707
- Partials 4414 4457 +43 ☔ View full report in Codecov by Sentry. |
erimatnor
force-pushed
the
merge-chunks-compressed
branch
2 times, most recently
from
3b2bca9 to
2cfb52f
Compare
erimatnor
force-pushed
the
merge-chunks-compressed
branch
from
2cfb52f to
bc91a59
Compare
Compressed chunks can be merged by applying the same copy+heap swap technique to the internal compressed heaps as done for the non-compressed heaps. However, special consideration is necessary for cases where some chunks are compressed and some are not. The way this is handled is to pick the first compressed chunk found among the input chunks, and then use that as the "result" chunk. In the next step all the chunks' non-compressed heaps are merged followed by all the "internal" compressed heaps. In the last step, the result chunk has its non-compressed and compressed heaps swapped with the merged ones, respectively. In all other regards, the merging works the same as before when merging non-compressed chunks.
erimatnor
force-pushed
the
merge-chunks-compressed
branch
from
bc91a59 to
702d543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compressed chunks can be merged by applying the same copy+heap swap technique to the internal compressed chunks as applied to non-compressed chunks. However, it is necessary to consider cases when some chunks are compressed and some are not.
The way this is handled is to pick the first compressed chunk found among the input chunks, and then use that as the "result" chunk. In the next step all the chunks' non-compressed heaps are merged followed by all the "internal" compressed heaps. In the last step, the result chunk has its non-compressed and compressed heaps swapped with the merged ones, respectively.
In all other regards, the merging works the same as before when merging non-compressed chunks.