Remove useless function from regression tests #7750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
added
tech-debt
fabriziomello
force-pushed
the
remove_useless_cagg_get_bucket_function
branch
from
8e5f08d to
bd5e4e6
Compare
|
@svenklemm, @gayyappan: please review this pull request.
|
svenklemm
approved these changes
Feb 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7750 +/- ##
==========================================
+ Coverage 80.06% 81.94% +1.87%
==========================================
Files 190 246 +56
Lines 37181 45258 +8077
Branches 9450 11305 +1855
==========================================
+ Hits 29770 37087 +7317
- Misses 2997 3715 +718
- Partials 4414 4456 +42 ☔ View full report in Codecov by Sentry. |
mkindahl
approved these changes
Feb 20, 2025
fabriziomello
force-pushed
the
remove_useless_cagg_get_bucket_function
branch
2 times, most recently
from
4e22a2d to
810a951
Compare
svenklemm
reviewed
Feb 20, 2025
svenklemm
requested changes
Feb 20, 2025
fabriziomello
force-pushed
the
remove_useless_cagg_get_bucket_function
branch
2 times, most recently
from
9548d4c to
7a1e2e7
Compare
fabriziomello
changed the title
fabriziomello
force-pushed
the
remove_useless_cagg_get_bucket_function
branch
from
7a1e2e7 to
0d1e769
Compare
The temporary function `cagg_get_bucket_function` was created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (timescale#7042) we added a new persistent function `cagg_get_bucket_function_info` as a replacement so used it instead. Leftover from timescale#7042 refactoring PR.
fabriziomello
force-pushed
the
remove_useless_cagg_get_bucket_function
branch
from
0d1e769 to
a45ebd0
Compare
svenklemm
approved these changes
Feb 21, 2025
gayyappan
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The temporary function
cagg_get_bucket_functionwas created to be used in the update script for 2.14.2 to 2.15.0 and for some regression tests, but in 2.16.0 (#7042) we added a new persistent functioncagg_get_bucket_function_infoas a replacement so used it instead.Leftover from #7042 refactoring PR.
Disable-check: force-changelog-file