Reduce privilege requirement in bgw_security #7758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7758 +/- ##
==========================================
+ Coverage 80.06% 81.95% +1.88%
==========================================
Files 190 247 +57
Lines 37181 45424 +8243
Branches 9450 11353 +1903
==========================================
+ Hits 29770 37225 +7455
- Misses 2997 3731 +734
- Partials 4414 4468 +54 ☔ View full report in Codecov by Sentry. |
The test `bgw_security` requires escalated privileges to modify `_timescaledb_config.bgw_job` and set the owner, which does not work when running tests on an instance without `SUPERUSER` privileges. Reduce the requirements for the test by switching role before adding the job, and hence avoid the need to update `_timescaledb_config.bgw_job` to set the owner. Commit also clarifies one error message generated on permission errors for a job.
mkindahl
force-pushed
the
fix-bgw_security-test
branch
from
ea6b14a to
afddde3
Compare
|
@akuzm, @antekresic: please review this pull request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
bgw_securityrequires escalated privileges to modify_timescaledb_config.bgw_joband set the owner, which does not work when running tests on an instance withoutSUPERUSERprivileges.Reduce the requirements for the test by switching role before adding the job, and hence avoid the need to update
_timescaledb_config.bgw_jobto set the owner.Disable-check: force-changelog-file