Implement Valence and Astroport Utils #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyleu
reviewed
Jun 27, 2024
bekauz
reviewed
Jun 27, 2024
bekauz
reviewed
Jul 1, 2024
There was a problem hiding this comment.
amazing work!
a lot of my feedback is high level and often opinionated so please feel free to push back if you disagree with anything!
other than that, one general point is that with PRs like this that migrate existing codebase and/or adds stuff on top of it, lets try to make the migration path for those existing codebases as seamless as possible. so for instance addresses that are hardcoded in the existing codebase should only change if they really need to.
again, great job!
Co-authored-by: bekauz <[email protected]>
stiiifff
approved these changes
Jul 3, 2024
stiiifff
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a TestContext builder mirroring the existing TestContext in the covenants repo. Astroport and valence helper functions are implemented as member functions of the TestContext, namely:
Astroport
tx_create_token_registrytx_create_factorytx_create_pooltx_fund_poolget_astroport_factoryget_astroport_poolValence
tx_create_auctions_managertx_create_auctiontx_fund_auctiontx_start_auctionNote: Additional helper functions have been added since this PR was created, including ones for Osmosis.