Start of supporting HDV over firewire. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aps-sids Can you see if there is anything worth merging in this pull request? |
| is_hdv = props.get('is-hdv', False) | ||
|
|
||
| # HDV streams generally have square pixels, while normal DV streams don't. | ||
| self.is_square = props.get('is-square', is_hdv) |
There was a problem hiding this comment.
720p HDV has square pixels, but it's not the case for 1080i HDV I guess. Is it safe to set options as square pixels?
There was a problem hiding this comment.
Normal 1080i has square pixels right? Is it just 1080i HDV which doesn't?
There was a problem hiding this comment.
http://en.wikipedia.org/wiki/HDV#Specifications says HDV 1080i has pixel aspect ratio of 1.33, not sure about normal 1080i.
|
Merged with https://github.com/aps-sids/flumotion-orig/commits/porting-firewire Will be merged in #7 when firewire is completely ported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.