Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mp4 muxer #5

Closed
wants to merge 2 commits into from
Closed

Mp4 muxer #5

wants to merge 2 commits into from

Conversation

mithro
Copy link
Member

@mithro mithro commented Dec 22, 2014

Adding a mp4 muxer, but also includes the justintv component?

@mithro
Copy link
Member Author

mithro commented Dec 22, 2014

@aps-sids - Looks like this change isn't merged into your branch. Can you see if there is anything worth merging in this pull request?

@landscape-bot
Copy link

Code Health
Repository health increased by 1% when comparing mp4-muxer 38fe00b on timvideos/flumotion to master 921550f on timvideos/flumotion

5 new problems were found (including 1 error and 3 code smells)
262 problems were fixed (including 15 errors and 21 code smells)

View the changes on Landscape.io

@ApsOps ApsOps closed this Dec 22, 2014
@ApsOps
Copy link
Member

ApsOps commented Dec 22, 2014

  1. JustinTV is dead, so that component is gone. Change it to create a generic RTMP component maybe?
  2. The mp4 muxer needs to be ported to gst1.0 first (seems little work though).

@ApsOps ApsOps reopened this Dec 22, 2014
@mithro
Copy link
Member Author

mithro commented Dec 22, 2014

It looks like justintv stuff was already merged into your stuff?

@ApsOps
Copy link
Member

ApsOps commented Dec 22, 2014

Yeah, justintv stuff was merged along with modern-twisted-fix

@mithro
Copy link
Member Author

mithro commented Dec 22, 2014

Okay, so we should port and merge this then?

On 22 December 2014 at 23:58, Amanpreet Singh [email protected]
wrote:

Yeah, justintv stuff was merged along with modern-twisted-fix

—
Reply to this email directly or view it on GitHub
#5 (comment).

@ApsOps
Copy link
Member

ApsOps commented Dec 22, 2014

Merged in #7

@ApsOps ApsOps closed this Dec 22, 2014
@ApsOps ApsOps deleted the mp4-muxer branch December 23, 2014 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ApsOps ApsOps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mithro @landscape-bot @ApsOps