Skip to content

Commit

Permalink
Merge pull request #191 from jacobweinstock/lacp
Browse files Browse the repository at this point in the history
Enabled LACP in iPXE:

## Description

<!--- Please describe what this PR is going to change -->
Helpful for environments with LACP enabled.

## Why is this needed

<!--- Link to issue you have raised -->

Fixes: #

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran to -->
<!--- see how your change affects other areas of the code, etc. -->


## How are existing users impacted? What migration steps/scripts do we need?

<!--- Fixes a bug, unblocks installation, removes a component of the stack etc -->
<!--- Requires a DB migration script, etc. -->


## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
  • Loading branch information
jacobweinstock authored Jan 29, 2025
2 parents 3b26a55 + 7b52ee4 commit 5e5bac4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ jobs:
- name: generate coverage report
run: make cover
- name: Codecov
uses: codecov/codecov-action@v5.1.1
uses: codecov/codecov-action@v5.3.1
- name: Build
run: make build
2 changes: 1 addition & 1 deletion binary/script/ipxe-customizations/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#define VLAN_CMD /* VLAN commands */
#define DOWNLOAD_PROTO_NFS /* NFS */
#define ROUTE_CMD /* Routing table management commands */
#define NET_PROTO_LACP /* Link Aggregation control protocol */

#undef CRYPTO_80211_WEP /* WEP encryption (deprecated and insecure!) */
#undef CRYPTO_80211_WPA2 /* Add support for stronger WPA cryptography */
Expand All @@ -23,7 +24,6 @@
#undef IMAGE_PNG /* PNG image support */
#undef IMAGE_PNM /* PNM image support */
#undef IWMGMT_CMD /* Wireless interface management commands */
#undef NET_PROTO_LACP /* Link Aggregation control protocol */
#undef NET_PROTO_STP /* Spanning Tree protocol */
#undef VNIC_IPOIB /* Infiniband IPoIB virtual NICs */

Expand Down

0 comments on commit 5e5bac4

Please sign in to comment.