-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
machine: adding support for waveshare-rp2040-tiny #4683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pobochiigo You want to add your board to the smoketest suite.
See https://github.com/tinygo-org/tinygo/blob/release/GNUmakefile#L516
done |
@aykevl @deadprogram are we OK with multiple smokes for a board or we want just one per board? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me, I'll let @aykevl or @deadprogram decide if 3 smokes is to much :D
I think one is enough. The smoke tests already take a while to run. |
@pobochiigo we just want to be sure we [smoke-]test all boards, so one smoke per board is enough. To test permutations of all boards with multiple examples would be good, but is a non-goal for now -- tests already take considerable time. Would you drop changes in lines from 757 to 762, please? Then we can merge the PR. Thank you! |
yep, sure |
Adding support for Waveshare rp2040-tiny board