Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine: adding support for waveshare-rp2040-tiny #4683

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

pobochiigo
Copy link

Adding support for Waveshare rp2040-tiny board

@pobochiigo pobochiigo marked this pull request as ready for review January 4, 2025 14:36
Copy link
Contributor

@ysoldak ysoldak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pobochiigo You want to add your board to the smoketest suite.
See https://github.com/tinygo-org/tinygo/blob/release/GNUmakefile#L516

@pobochiigo
Copy link
Author

@pobochiigo You want to add your board to the smoketest suite. See https://github.com/tinygo-org/tinygo/blob/release/GNUmakefile#L516

done

@pobochiigo pobochiigo requested a review from ysoldak January 10, 2025 16:32
@ysoldak
Copy link
Contributor

ysoldak commented Jan 12, 2025

@aykevl @deadprogram are we OK with multiple smokes for a board or we want just one per board?

Copy link
Contributor

@ysoldak ysoldak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, I'll let @aykevl or @deadprogram decide if 3 smokes is to much :D

@deadprogram
Copy link
Member

I think one is enough. The smoke tests already take a while to run.

@ysoldak
Copy link
Contributor

ysoldak commented Jan 13, 2025

@pobochiigo we just want to be sure we [smoke-]test all boards, so one smoke per board is enough.

To test permutations of all boards with multiple examples would be good, but is a non-goal for now -- tests already take considerable time.

Would you drop changes in lines from 757 to 762, please? Then we can merge the PR. Thank you!

@pobochiigo
Copy link
Author

@pobochiigo we just want to be sure we [smoke-]test all boards, so one smoke per board is enough.

To test permutations of all boards with multiple examples would be good, but is a non-goal for now -- tests already take considerable time.

Would you drop changes in lines from 757 to 762, please? Then we can merge the PR. Thank you!

yep, sure

@pobochiigo pobochiigo requested a review from ysoldak January 13, 2025 20:58
@ysoldak ysoldak merged commit b15adf2 into tinygo-org:dev Jan 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants