Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/nrf52xxx/spi/tests #4700

Closed
wants to merge 4 commits into from
Closed

Feat/nrf52xxx/spi/tests #4700

wants to merge 4 commits into from
+138 −39

Conversation

milkpirate
Copy link

@milkpirate milkpirate commented Jan 14, 2025 •
edited
Loading

As requested per #4660 (review)

What I did

SPI

  • Moved the tests into separate PR
  • Depends on: Feat/nrf52xxx/spi/improve #4699
  • Adopt testify to improve the quality and maintainability of the tests while reducing boilerplate code. Given its popularity and low cost, adopting testify will benefit this project in the long run. Other well regarded options are welcome as well and can be implemented if needed.

Open questions?

  • How to run the added tests?

@milkpirate milkpirate mentioned this pull request Jan 14, 2025
Closed
@milkpirate
Copy link
Author

Became obsolete with decision against ApplyTo(() (#4699 (review)).

@milkpirate milkpirate closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@milkpirate