jWorklfow enhancements #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsFlow().step(fn);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've done a little bit of work on your library. We're using it in a game project because it's concept is really simple and nice. Some things are re-builded internally because of performance lacks. We replaced the array system by a index system which enables your lib to have different instances of the same flow running at the same time. Furthermore we added a revise function to the baton which makes able to create repeating steps of one flow function ( like loading a bunch of images ) without making unnecessary hacks like creating n real andThen steps. At least there is now a new context handling. If a step does not have an own context defined then the library calls the function with the context of the start call (if given).
This version changes a lot of things internally, but is 100% API compatible when you use a
var JSFLOW_JWORKFLOW_API_COMPATIBLE_MODE = truemark in your window object. You can check that by starting the lib test. It includes your original test script which solves 100% pass in my browser. The reason for that is mostly the name change and the order function. Of course in a merge the order code could be merged into the factory function of the lib.