Jl/page decorations improvements #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenbo
reviewed
Mar 20, 2024
mortenbo
reviewed
Mar 21, 2024
mortenbo
reviewed
Mar 21, 2024
mortenbo
reviewed
Mar 21, 2024
klarstrup
approved these changes
Mar 22, 2024
|
Hi @mortenbo, can we merge this now? |
|
It's in prod now but I have one change needed: link and embed_link are now strings. So if embed_link is set, use that. If else link is set, use that. 
|
|
@mortenbo here's how it should look like now 🙂
|
|
@jrlarano Super, what about if link? |
|
Link is like this 🙂 |
|
OK, great. We need to fix this: https://github.com/tjek/tjek-js-sdk/pull/225/files#diff-56e8833b30816a4984798688ef87a98d9e5093e18e1ba083ebe1446d64b54e9bR75. You need to set sandbox="allow-scripts allow-same-origin" |
|
Otherwise, it's fine to merge and deploy if @klarstrup agrees with the PR. |
|
@klarstrup Once deployed, I'd like to get this into Vizsla too. |
klarstrup
approved these changes
Apr 19, 2024
|
Is this a regression? |
|
no that test just sucks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
PageDecorations should be passed on applyHotspots to render its hotspost similar to normal hotspots
Eg:
bootstrapper.applyHotspots(sgnViewer, hotspots, sgnPageDecorations);