-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable UTM query param #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a bit opposite deleting utm - vs. not setting it if disabled.
Yeah, but this is because the webshop_link from offer details coming from Squid always contain UTMs. We only added an option to overwrite its default values and an option to remove it if it's disabled. |
Okay. Why the option to remove the params in the first place? |
It's because one of our clients don't like having UTM params when they redirect to the webshop_link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the real solution is to add a new field in Squid so you have two URLs: with and without UTM and then the SDK uses the one without, but this is fine for now.
Actually, maybe we should completely remove UTM parameters in general using the SDK instead of it being an option? They are not needed when it's the client themselves integrating. |
Nvm my last comment. We'll make it default in the CMS instead, Jakob informed me. |
@mortenbo I see. Does this mean that we won't need this change now? |
Yes, as long as we in the CMS add disable-utm param as a default param in the integration output. |
Relates to: https://github.com/tjek/octopus/issues/400