Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagedecoration hotspot click event #230

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

jrlarano
Copy link
Contributor

No description provided.

@jrlarano jrlarano requested review from mortenbo and klarstrup April 24, 2024 11:49
@jrlarano jrlarano merged commit 5b6a93b into develop Apr 24, 2024
4 of 5 checks passed
@jrlarano jrlarano deleted the jl/fix-page-decoration-hotspot branch April 24, 2024 12:02
@jrlarano
Copy link
Contributor Author

Hi @klarstrup , we need your help in deploying this 🙂

@klarstrup
Copy link
Member

[email protected] is now live on all channels 😁

@mortenbo Maybe it's about time we get @jrlarano set up with the NPM and AWS creds required to publish the SDK?

@mortenbo
Copy link
Member

@klarstrup What would it require with a similar deploy approach like Squid? Could maybe be powered by GH Actions fully.

@klarstrup
Copy link
Member

The sdk publish script has a lot more nuance than tagging a commit, multiple packages and versions that change differently requiring multiple inputs. So i don't think that would be possible.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants