Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix open link in tab treated as popup by Safari mobile #231

Merged
merged 1 commit into from
May 18, 2024
Merged

Fix open link in tab treated as popup by Safari mobile #231

merged 1 commit into from
May 18, 2024

Conversation

jrlarano
Copy link
Contributor

@jrlarano jrlarano requested a review from klarstrup May 16, 2024 11:17
@jrlarano jrlarano merged commit 19ca3c9 into develop May 18, 2024
5 checks passed
@jrlarano jrlarano deleted the jl/fix-open-link branch May 18, 2024 07:16
@jrlarano
Copy link
Contributor Author

Hi @klarstrup we need your help again to deploy this. As well as this PR #232

@klarstrup
Copy link
Member

klarstrup commented May 23, 2024 •
edited
Loading

Ah sorry for pickling this!!!

This is now out as of

✔ Published @tjek/sdk@latest v0.14.0
✔ Published shopgun-sdk@latest v4.20.0

@jrlarano
Copy link
Contributor Author

@klarstrup Thank you so much! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klarstrup klarstrup klarstrup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrlarano @klarstrup