fix: don't nest empty group keys, better follow slog.Hanlder interface #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @aknuds1 |
tjhop
force-pushed
the
fix/no-nesting-empty-group-keys
branch
2 times, most recently
from
9d555f7 to
cb5b966
Compare
Test snippets to show change: Before: ``` level=info caller=slogtest.go:97 time=2025-01-14T17:36:28.125642737-05:00 msg=msg a=b .G.c=d e=f ``` After: ``` level=info caller=slogtest.go:97 time=2025-01-14T18:09:01.253906842-05:00 msg=msg a=b G.c=d e=f ``` Signed-off-by: TJ Hoplock <[email protected]>
tjhop
force-pushed
the
fix/no-nesting-empty-group-keys
branch
from
cb5b966 to
11db26d
Compare
|
yay, PR tests work \o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test snippets to show change:
Before:
After:
Signed-off-by: TJ Hoplock [email protected]