Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unmaintainable parallel logic with workers #1

Open
wants to merge 16 commits into
base: clean-near-unmaintainable-parallel-logic-53593
Choose a base branch
from
Open

Cleanup unmaintainable parallel logic with workers #1

wants to merge 16 commits into from

Conversation

tjwald
Copy link
Owner

@tjwald tjwald commented Oct 14, 2022 •
edited
Loading

PR for Issue: issue

  • Created Worker object for each of the 3 implementations of the For Worker: body, state, and local.
  • Created WorkerFactory for creating the replicable tasks

tjwald added 2 commits October 13, 2022 10:39
@tjwald
WIP
7c48aa6
@tjwald
* created worker factories
67339fc 
* Created joint functions for all For 32 vs 64 entry points
@tjwald tjwald self-assigned this Oct 14, 2022
tjwald added 12 commits October 14, 2022 04:13
@tjwald
Merge branch 'clean-near-unmaintainable-parallel-logic-53593' into cl…
5bf86b3 
…eanup-unmaintainable-parallel-logic-with-workers

# Conflicts:
#	src/libraries/System.Threading.Tasks.Parallel/src/System/Threading/Tasks/Parallel.cs
@tjwald
combined foreach workers with for workers.
903e5fa 
Now going to work on migrating foreach to new imp
@tjwald
migrated foreach to workers
0bac5b7
@tjwald
removed WorkerFactories by inlining workerBodyFactories into worker
2a15142 
Removed unnecessary object initializations from entry points after factory simplification.
@tjwald
organized the code and added regions for easy use.
43440a7
@tjwald
moved guard clauses from entry points to worker body factories when p…
93a8505 
…ossible.

 moved Common code from orderable and partitioner foreach implementation - prep for merge with For worker.
 Fixed line breaks
@tjwald
merged foreach and for
2d91975
@tjwald
fixed typing issue
c64b4c5
@tjwald
fixed operation type and indentation
7b39fc4
@tjwald
reorganizing classes and fixed naming
32b14e0
@tjwald
undo naming refactoring
b264d4d
@tjwald
moved helpers to bottom
3f0a52c
@tjwald tjwald mentioned this pull request Nov 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tjwald tjwald

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tjwald