Union#to_s follows RBS/Lint/AmbiguousOperatorPrecedence

At present, the result of `Union#to_s` does not respect `RBS/Lint/AmbiguousOperatorPrecedence` cop from rubocop-on-rbs. It would be better to wrap intersections in unions by paranthesis. * Before: `Integer | String & bool` * After: `Integer | (String & bool)` ref: soutaro/rbs-inline#174
tk0miya · Jan 13, 2025 · 09a3328 · 09a3328
1 parent d421a15
commit 09a3328
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/lib/rbs/types.rb b/lib/rbs/types.rb
@@ -751,10 +751,19 @@ def sub(s)
       end
 
       def to_s(level = 0)
+        strs = types.map do |ty|
+          case ty
+          when Intersection
+            ty.to_s([1, level].max)
+          else
+            ty.to_s(level)
+          end
+        end
+
         if level > 0
-          "(#{types.join(" | ")})"
+          "(#{strs.join(" | ")})"
         else
-          types.join(" | ")
+          strs.join(" | ")
         end
       end
 

diff --git a/test/rbs/types_test.rb b/test/rbs/types_test.rb
@@ -23,9 +23,9 @@ def test_to_s
     assert_equal "(String | bool)?", parse_type("(String | bool)?").to_s
     assert_equal "String & bool?", parse_type("String & bool?").to_s
     assert_equal "(String & bool)?", parse_type("(String & bool)?").to_s
-    assert_equal "Integer | String & bool", parse_type("Integer | String & bool").to_s
+    assert_equal "Integer | (String & bool)", parse_type("Integer | String & bool").to_s
     assert_equal "(Integer | String) & bool", parse_type("(Integer | String) & bool").to_s
-    assert_equal "(Integer | String & bool)?", parse_type("(Integer | String & bool)?").to_s
+    assert_equal "(Integer | (String & bool))?", parse_type("(Integer | String & bool)?").to_s
     assert_equal "((Integer | String) & bool)?", parse_type("((Integer | String) & bool)?").to_s
     assert_equal "^() -> void", parse_type("^() -> void").to_s
     assert_equal "(^() -> void)?", parse_type("(^() -> void)?").to_s