Added compatibility for all Django versions up to 2.1 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tkaemming Could you please manage this? First pull #60 and #64, than this and than release it as version |
|
You can try using another package called 'django-hosts' if you can't hold your breath for django-subdomains. |
|
@tkaemming Please merge. |
|
@tkaemming Yes please. |
|
@tkaemming Can you please merge? |
PetrDlouhy
changed the title
|
@tkaemming I added testing also for Django 2.1, which passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is compilation of several branches around GitHub that target compatibility with newer Django versions.
The #60 and #64 patches are part of this, so I suggest pulling them first.
I finished this by fixing tests in all Django versions (1.4-2.0).