Update binary_operator_definitions regex to not stylize commented definitions

[FedericoPonzi]

As per title, this seems to be the culprit.
Diagnosed by removing the definitions from the grammar file one at a time, reload the plugin and checked against the very helpful MRE provided in #361. Removing binary_operator_definitions made it working again.
Unescaped regex:

(\w+\s*(\(?[-<:>=&@\/%#!X\$\*\+\.\|\?\^\\]+\)?|\\[a-z]+\s)\s*\w+)\s*==(?!==)

From regex101:

Fix: I included a negative look-behind to exclude matching whenever this string starts with the sequence "*". It should still match \ and * separately.

I included a test for the grammar that was failing before my fix, identifying the definition in the comment as something else. Please give it a try and let me know if anything else is breaking for you.

Highlight before the patch:

Highlight after the patch:

Unescaped regex:

(\w+\s*(\(?(?!\\\*)[-<:>=&@\/%#!X\$\*\+\.\|\?\^\\]+\)?|\\[a-z]+\s)\s*\w+)\s*==(?!==)

From regex101:

---

(just some utils) Original unescaped regex:

const fs = require('fs');
const jsonData = JSON.parse(fs.readFileSync('regex.json', 'utf8'));
const regex = new RegExp(jsonData.match, 'g');
console.log("Regex as a string:", regex.source);
// Write the regex back to a new JSON file
const outputJsonData = { match: regex.source };
console.log(JSON.stringify(outputJsonData, null, 2));

[FedericoPonzi]

This is the before:

the --- x part is styled differently, I'm not sure if it's expected or not. I will take another look later.

[lemmy]

@FedericoPonzi Do you know if it is possible to use a real parser for syntax highlighting in VSCode instead of relying on regular expressions?

[FedericoPonzi]

After some research: https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide

Syntax highlight can be implemented via LSP, but this is usually an additional layer on top called Semantic Highlight: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide

See rust syntax overview for reference: https://marketplace.visualstudio.com/items?itemName=dustypomerleau.rust-syntax

So my understanding is that you can implement it using LSP, but the regex based highlight should still be used for the first pass.

[FedericoPonzi]

I had some issues due to the escaping lol. I've updated the util code for unescaping to use javascript, in this way regex101 was correctly showing the wrong matches.