Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groups: fix broken private group initiated invite flow #4398

Merged
merged 1 commit into from
Feb 11, 2025
Merged

groups: fix broken private group initiated invite flow #4398

merged 1 commit into from
Feb 11, 2025
+3 −1

Conversation

mikolajpp
Copy link
Collaborator

A condition added in 6a172f0 to prevent double group joins had broken the private group invite flow.

The following scenario would result in a group invite being permanently stuck

  1. Alice hosts a private group
  2. Bob initiates a join request to the group, creating an entry in gangs that is at %knocking progress.
  3. A group invite send by Alice would now be mistakenly dropped by Bob.

@mikolajpp mikolajpp requested review from Fang- and arthyn February 7, 2025 10:11
Fang-
Fang- approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@mikolajpp mikolajpp merged commit ba2afbc into develop Feb 11, 2025
3 of 4 checks passed
@mikolajpp mikolajpp deleted the mp/better-groups branch February 11, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fang- Fang- Fang- approved these changes

@arthyn arthyn Awaiting requested review from arthyn

Assignees
No one assigned
Labels
desk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikolajpp @Fang- @jamesacklin