Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(formats): skip committing to empty header values #376

Closed
wants to merge 1 commit into from
Closed

fix(formats): skip committing to empty header values #376

wants to merge 1 commit into from

Conversation

sinui0
Copy link
Member

@sinui0 sinui0 commented Oct 25, 2023

This PR fixes a bug which causes an error when empty header values are present in an HTTP record.

Changes

  • Skip committing to header values which are empty

@sinui0 sinui0 requested review from themighty1 and th4s October 25, 2023 21:55
th4s
th4s reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@th4s th4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also adapt the Http{Request, Response}CommitmentBuilder::header methods?

@sinui0
Copy link
Member Author

sinui0 commented Feb 1, 2024

Closing in favor of #380

@sinui0 sinui0 closed this Feb 1, 2024
@sinui0 sinui0 deleted the fix/commit-empty-values branch February 14, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th4s th4s th4s left review comments

@themighty1 themighty1 Awaiting requested review from themighty1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinui0 @th4s