-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use logging filter, remove otel. #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me whether this is already the case, but let's enable logs for all those dependencies by default (tlsn_verifier
and tls_mpc
).
I think it would be nice if the filter
field is an optional which overrides the level
field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Co-authored-by: Hendrik Eeckhaut <[email protected]>
This addresses #412
Switched from using config file to indicate log verbosity level to using RUST_LOG env var which is much more flexibleSpanData
struct because it was temporarily setup to export to stdout — we can remove it for now since we're not using any opentelemetry tool yet