Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logging filter, remove otel. #422

Merged
merged 7 commits into from
Feb 9, 2024
Merged

Use logging filter, remove otel. #422

merged 7 commits into from
Feb 9, 2024

Conversation

yuroitaki
Copy link
Member

@yuroitaki yuroitaki commented Feb 6, 2024

This addresses #412

  • Switched from using config file to indicate log verbosity level to using RUST_LOG env var which is much more flexible
  • Removed opentelemetry setup code which is flooding the logs with SpanData struct because it was temporarily setup to export to stdout — we can remove it for now since we're not using any opentelemetry tool yet
  • Fixed the config file logging setting to use logging filter directive instead of just verbosity level

@yuroitaki yuroitaki requested review from heeckhau and sinui0 February 6, 2024 08:42
notary-server/README.md Outdated Show resolved Hide resolved
@yuroitaki yuroitaki requested a review from heeckhau February 6, 2024 15:43
@yuroitaki yuroitaki changed the title Use env var for logging filter, remove otel. Use logging filter, remove otel. Feb 7, 2024
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me whether this is already the case, but let's enable logs for all those dependencies by default (tlsn_verifier and tls_mpc).

I think it would be nice if the filter field is an optional which overrides the level field.

notary-server/README.md Outdated Show resolved Hide resolved
notary-server/config/config.yaml Outdated Show resolved Hide resolved
notary-server/config/config.yaml Outdated Show resolved Hide resolved
notary-server/config/config.yaml Show resolved Hide resolved
notary-server/README.md Show resolved Hide resolved
@yuroitaki yuroitaki requested a review from sinui0 February 7, 2024 09:51
Copy link
Member

@sinui0 sinui0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

components/tls/tls-client/src/backend/standard.rs Outdated Show resolved Hide resolved
components/tls/tls-client/tests/api.rs Outdated Show resolved Hide resolved
@yuroitaki
Copy link
Member Author

yuroitaki commented Feb 9, 2024

By the way @sinui0 @heeckhau please don't merge this first even after all approvals have been obtained when I am away the next few days — since there's a format change of the config file, I'd like to change that in our AWS server first and test before CD kicks in which ll fail otherwise

notary-server/README.md Outdated Show resolved Hide resolved
Co-authored-by: Hendrik Eeckhaut <[email protected]>
@yuroitaki yuroitaki merged commit de4d024 into dev Feb 9, 2024
15 checks passed
@sinui0 sinui0 deleted the notary-server/logging branch February 14, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants