Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(alpha.8) - Refactor key-exchange crate #685

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Conversation

th4s
Copy link
Member

@th4s th4s commented Jan 15, 2025

This PR adapts key-exchange to the new mpz vm.

@sinui0
Copy link
Member

sinui0 commented Jan 21, 2025

Couple initial thoughts:

  1. I think we can pull this in as a module in the tls-mpc crate. This can wait until after we have all the tests passing.
  2. The equality check can be behind the interface, handled automatically in flush.
  3. As discussed a while back, we can ditch the trait and just couple directly to the MpcKeyExchange struct. This should remove a ton of noise in the code caused by trait bounds and fully qualified trait method calls.

@th4s
Copy link
Member Author

th4s commented Jan 21, 2025

ad 1) I am not necessarily against, but what is the advantage? tls-mpc is already getting pretty big.
ad 3) The trait KeyExchange actually helps to reduce the noise in MpcTlsLeader, because it hides the share conversion generics in the implementation MpcKeyExchange<C0, C1>, no?

@sinui0 sinui0 self-requested a review January 22, 2025 00:08
@sinui0 sinui0 merged commit 001b050 into alpha.8-branch Jan 22, 2025
0 of 5 checks passed
@sinui0 sinui0 deleted the key-exchange-crate branch January 22, 2025 00:09
@th4s
Copy link
Member Author

th4s commented Jan 22, 2025

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants