More explanatory text.. Fixes #587. Fixes #591 #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2024
wbl
reviewed
Feb 18, 2024
draft-ietf-tls-esni.md
Outdated
| DNS results, if one is provided. | ||
|
|
||
|
|
sftcd
reviewed
Feb 18, 2024
| key not known to the server. | ||
|
|
||
| * The server has ECH configured but the client has a ECH configuration | ||
| and so is attempting ECH. |
There was a problem hiding this comment.
Missing a negative in 2nd bullet above?
|
other than the above, this change seems fine |
martinthomson
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Any point saying that:
This makes availability of a certificate for the public name - and its associated private key - a critical component for server deployment of ECH. This certificate is used both to recover from transient misconfiguration problems and to disable ECH in the event that a server cannot continue to support the capability.
draft-ietf-tls-esni.md
Outdated
Comment on lines
264
to
265
| * The server has ECH configured but the client has a ECH configuration | ||
| and so is attempting ECH. |
There was a problem hiding this comment.
Suggested change
| * The server has ECH configured but the client has a ECH configuration | |
| and so is attempting ECH. | |
| * The server does not have ECH configured but the client has a ECH configuration | |
| and so is attempting ECH. |
ekr
commented
Feb 25, 2024
ekr
commented
Feb 25, 2024
Co-authored-by: Martin Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the overview section to be a bit clearer and clarified the misconfiguration pieces.