-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor to indicators error message #396
base: devel
Are you sure you want to change the base?
Conversation
…puts meaningful error message
throw a warning for constant outcome(s) and covariates, and drop constant constant covariates
For covariates and outcome(s) that are constant (i.e., have one unique value/level), we only need to throw a warning. The error here is not necessary, e.g. imagine if someone creates a task for prediction with just one observation |
Hi @nhejazi and/or @jeremyrcoyle could you please take a look at the test errors here? I am not sure what's going on. Perhaps an error with GitHub Actions R with Java, or maybe we need to change the Java parameters for |
@rachaelvp and @tq21 sorry I missed this (not sure how), but the failure seems only be related to a weird issue with installing Lines 5 to 15 in 2bc71d8
|
@rachaelvp if you've reviewed these changes and they look good, then my suggestion would be to merge into |
Fix issue #285. In addition, I added a check to ensure all covariates and outcomes have more than one category (categorical variable) or unique value (continuous variable). Code will fail immediately if users try to define an sl3_Task with data that contains columns with one value. An error message indicating the names of those columns will be printed.