Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(editor): optimize the search for the closest element #9587

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jan 8, 2025

Closes: BS-2275

Copy link
Contributor Author

fundon commented Jan 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon changed the title perf(editor): optimize the search for the closest element perf(editor): optimize the search for the closest elements Jan 8, 2025
@fundon fundon changed the title perf(editor): optimize the search for the closest elements perf(editor): optimize the search for the closest element Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 45.94595% with 60 lines in your changes missing coverage. Please review.

Project coverage is 52.74%. Comparing base (5ff2254) to head (2950926).
Report is 10 commits behind head on canary.

Files with missing lines Patch % Lines
...components/src/drag-indicator/file-drop-manager.ts 48.64% 38 Missing ⚠️
...te/affine/shared/src/utils/dnd/calc-drop-target.ts 0.00% 12 Missing ⚠️
...suite/affine/widget-drag-handle/src/drag-handle.ts 62.50% 6 Missing ⚠️
...uite/affine/shared/src/utils/dom/point-to-block.ts 60.00% 2 Missing ⚠️
...ksuite/affine/block-database/src/database-block.ts 0.00% 1 Missing ⚠️
...get-drag-handle/src/watchers/drag-event-watcher.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9587      +/-   ##
==========================================
+ Coverage   52.69%   52.74%   +0.05%     
==========================================
  Files        2176     2176              
  Lines       97595    97591       -4     
  Branches    16619    16621       +2     
==========================================
+ Hits        51427    51476      +49     
+ Misses      44723    44664      -59     
- Partials     1445     1451       +6     
Flag Coverage Δ
server-test 78.02% <ø> (ø)
unittest 32.41% <15.31%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/01_08_optimize_the_search_for_the_closest_elements branch 4 times, most recently from ac9c566 to 288e37d Compare January 8, 2025 16:52
@fundon fundon marked this pull request as ready for review January 8, 2025 16:53
@fundon fundon requested a review from a team as a code owner January 8, 2025 16:53
@graphite-app graphite-app bot requested a review from forehalo January 8, 2025 16:53
@fundon fundon force-pushed the fundon/01_08_optimize_the_search_for_the_closest_elements branch from 288e37d to 2950926 Compare January 9, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant