Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(electron): close inactive views when switching workspace #9601

Merged
merged 1 commit into from
Jan 10, 2025
Merged

feat(electron): close inactive views when switching workspace #9601

merged 1 commit into from
Jan 10, 2025

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 9, 2025 •
edited
Loading

fix AF-1355

@pengx17 pengx17 mentioned this pull request Jan 9, 2025
Merged
@pengx17 Graphite App
Copy link
Collaborator Author

pengx17 commented Jan 9, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review January 9, 2025 05:13
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch from 8bec475 to 60c176b Compare January 9, 2025 06:09
@pengx17 pengx17 requested a review from a team as a code owner January 9, 2025 06:09
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from 05c101f to 5e2a131 Compare January 9, 2025 06:09
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch from 60c176b to b4d7834 Compare January 9, 2025 06:12
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from 5e2a131 to 5351c59 Compare January 9, 2025 06:12
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch from b4d7834 to c8623f5 Compare January 9, 2025 06:45
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from 5351c59 to d387a35 Compare January 9, 2025 06:46
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch from c8623f5 to 5d2a8e0 Compare January 9, 2025 06:59
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from d387a35 to 6f1e45f Compare January 9, 2025 06:59
@pengx17 pengx17 force-pushed the xp/01-08-fix_ios_ignore_some_build_files branch from 5d2a8e0 to 7c50e3d Compare January 9, 2025 07:14
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from 6f1e45f to c9086f2 Compare January 9, 2025 07:14
@pengx17 pengx17 changed the base branch from xp/01-08-fix_ios_ignore_some_build_files to graphite-base/9601 January 9, 2025 08:04
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 9, 2025 •
edited
Loading

Merge activity

  • Jan 9, 3:16 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 9, 3:56 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Test (3)').
  • Jan 10, 4:52 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 10, 5:08 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/9601 to canary January 9, 2025 08:36
pengx17 added a commit that referenced this pull request Jan 9, 2025
@pengx17
feat(electron): close inactive views when switching workspace (#9601)
9ef6592 
fix AF-1355
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from c9086f2 to 9ef6592 Compare January 9, 2025 08:37
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.83%. Comparing base (93c585a) to head (7d2ee8d).
Report is 1 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff             @@
##           canary    #9601      +/-   ##
==========================================
+ Coverage   52.80%   52.83%   +0.03%     
==========================================
  Files        2180     2180              
  Lines       98469    98469              
  Branches    16717    16717              
==========================================
+ Hits        51993    52026      +33     
+ Misses      45034    45031       -3     
+ Partials     1442     1412      -30
Flag Coverage Δ
server-test 77.77% <ø> (ø)
unittest 32.33% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pengx17 added a commit that referenced this pull request Jan 10, 2025
@pengx17
feat(electron): close inactive views when switching workspace (#9601)
984d416 
fix AF-1355
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from 9ef6592 to 984d416 Compare January 10, 2025 02:48
pengx17 added a commit that referenced this pull request Jan 10, 2025
@pengx17
feat(electron): close inactive views when switching workspace (#9601)
9ad2e89 
fix AF-1355
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from 984d416 to 9ad2e89 Compare January 10, 2025 08:41
pengx17 added a commit that referenced this pull request Jan 10, 2025
@pengx17
feat(electron): close inactive views when switching workspace (#9601)
c051446 
fix AF-1355
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from 9ad2e89 to c051446 Compare January 10, 2025 08:49
pengx17 added a commit that referenced this pull request Jan 10, 2025
@pengx17
feat(electron): close inactive views when switching workspace (#9601)
fd14535 
fix AF-1355
@pengx17 pengx17 force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from c051446 to fd14535 Compare January 10, 2025 09:00
@Brooooooklyn Brooooooklyn force-pushed the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch from fd14535 to 7d2ee8d Compare January 10, 2025 09:52
@graphite-app graphite-app bot merged commit 7d2ee8d into canary Jan 10, 2025
61 checks passed
@graphite-app graphite-app bot deleted the xp/01-09-feat_electron_close_inactive_views_when_switching_workspace branch January 10, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

@EYHN EYHN Awaiting requested review from EYHN

@JimmFly JimmFly Awaiting requested review from JimmFly

@CatsJuice CatsJuice Awaiting requested review from CatsJuice

@forehalo forehalo Awaiting requested review from forehalo

Assignees
No one assigned
Labels
app:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pengx17 @Brooooooklyn