Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): selection as store extension #9605

Merged

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review January 9, 2025 07:44
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner January 9, 2025 07:44
@graphite-app graphite-app bot requested a review from forehalo January 9, 2025 07:44
@github-actions github-actions bot added the test Related to test cases label Jan 9, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.84%. Comparing base (c2d8c23) to head (126ab18).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ore/src/extension/selection/selection-extension.ts 70.37% 8 Missing ⚠️
...ework/block-std/src/range/inline-range-provider.ts 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9605      +/-   ##
==========================================
- Coverage   52.86%   52.84%   -0.02%     
==========================================
  Files        2180     2180              
  Lines       98438    98426      -12     
  Branches    16690    16690              
==========================================
- Hits        52035    52011      -24     
+ Misses      44986    44967      -19     
- Partials     1417     1448      +31     
Flag Coverage Δ
server-test 77.77% <ø> (-0.06%) ⬇️
unittest 32.36% <73.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone force-pushed the 01-09-feat_editor_selection_as_store_extension branch from 3d02763 to f6af6d0 Compare January 9, 2025 07:55
@graphite-app graphite-app bot requested review from EYHN, JimmFly, pengx17 and CatsJuice and removed request for EYHN January 9, 2025 07:55
@Saul-Mirone Saul-Mirone force-pushed the 01-09-feat_editor_selection_as_store_extension branch 4 times, most recently from 77bd1ba to d72dedd Compare January 9, 2025 09:56
Copy link

graphite-app bot commented Jan 9, 2025

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 01-09-feat_editor_selection_as_store_extension branch from d72dedd to 126ab18 Compare January 9, 2025 11:49
@graphite-app graphite-app bot merged commit 126ab18 into canary Jan 9, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-09-feat_editor_selection_as_store_extension branch January 9, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants