Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add new bs dnd adapter #9717

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jan 15, 2025

No description provided.

Copy link
Collaborator Author

pengx17 commented Jan 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added mod:component test Related to test cases app:core labels Jan 15, 2025
@pengx17 pengx17 marked this pull request as ready for review January 15, 2025 14:40
@pengx17 pengx17 requested a review from a team as a code owner January 15, 2025 14:40
@pengx17 pengx17 requested a review from doouding January 15, 2025 14:40
@pengx17 pengx17 force-pushed the xp/01-15-feat_core_add_new_bs_dnd_adapter branch from 381596d to 808a100 Compare January 16, 2025 03:06
@doouding doouding force-pushed the 01-09-refactor_rewrite_blocksuite_dnd branch 3 times, most recently from 62116ca to 95c065e Compare January 16, 2025 12:09
Copy link

graphite-app bot commented Jan 16, 2025

Merge activity

  • Jan 16, 7:37 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Jan 16, 8:54 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 16, 9:12 AM EST: A user merged this pull request with the Graphite merge queue.

@doouding doouding changed the base branch from 01-09-refactor_rewrite_blocksuite_dnd to graphite-base/9717 January 16, 2025 12:37
@pengx17 pengx17 force-pushed the xp/01-15-feat_core_add_new_bs_dnd_adapter branch from 808a100 to 58ecd85 Compare January 16, 2025 13:11
@pengx17 pengx17 force-pushed the graphite-base/9717 branch from 95c065e to 9971719 Compare January 16, 2025 13:11
@pengx17 pengx17 changed the base branch from graphite-base/9717 to canary January 16, 2025 13:11
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.97%. Comparing base (9971719) to head (7dc470e).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9717      +/-   ##
==========================================
- Coverage   52.99%   52.97%   -0.03%     
==========================================
  Files        2199     2199              
  Lines       99038    99038              
  Branches    16828    16828              
==========================================
- Hits        52489    52469      -20     
+ Misses      45144    45131      -13     
- Partials     1405     1438      +33     
Flag Coverage Δ
server-test 78.08% <ø> (-0.06%) ⬇️
unittest 32.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/01-15-feat_core_add_new_bs_dnd_adapter branch from 58ecd85 to 5d747fe Compare January 16, 2025 13:36
@pengx17 pengx17 force-pushed the xp/01-15-feat_core_add_new_bs_dnd_adapter branch from 5d747fe to 7dc470e Compare January 16, 2025 13:54
@graphite-app graphite-app bot merged commit 7dc470e into canary Jan 16, 2025
61 checks passed
@graphite-app graphite-app bot deleted the xp/01-15-feat_core_add_new_bs_dnd_adapter branch January 16, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants